Update kinds_of_types.rst: keep old anchor for #no-strict-optional #19828
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this will work, since something else has the same anchor on a different page... See python#19252, though.
|
Possibly we should just use clever redirects instead, which is sort of a Sphinx feature to some extent. (Edit: I may one day figure out Sphinx redirects, but for now this fix is fine.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19252 (comment)
This way, when people get the old documentation link, it will continue to go to the right place.
I have looked at the documentation that gets generated locally to see if everything still works. It does. In our vast panoply of documentation, we now have two very similar refs,
no-strict-optionalandno_strict_optional(used in https://mypy.readthedocs.io/en/stable/common_issues.html#no-errors-reported-for-obviously-wrong-code to link to https://mypy.readthedocs.io/en/stable/command_line.html#no-strict-optional) but the software handles them fine, without getting confused.